feat(admin-nav): move config items into a sidebar accordion menu - #1534
Merged
Conversation
Contributor
|
Can you resolve conflicts @maxijabase ? 👍 |
Keep AdminNavCatalog::sectionsFor for admin section slugs; drop the inline AdminTabs catalog that landed on main via sbpp#1532.
Rushaway
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1490
Admin section nav no longer lives in a second rail next to the main sidebar. Pattern A pages (
?section=…) keep the same URLs and routing, but their children now open as accordions under Admins / Servers / Bans / Groups / Settings / Mods in the main sidebar. That frees ~14rem of content width and kills the double-menu feel the issue called out.Sbpp\View\AdminNavCatalogis the single source for section catalogs (navbar accordion + page-handler slug defaults). Permission andconfig.enable*gates match the oldAdminTabsfilter.AdminTabswith a non-empty tab list is a no-op. Empty calls still render the edit-* Back link..page-sectioninset so they line up with the page body after the second rail went away.Docs (
AGENTS.md,ARCHITECTURE.md), E2E selectors, and PHPUnit (includingAdminNavCatalogTest) updated for the new testids (nav-admin-<endpoint>-<slug>).Test plan
aria-current="page", category summary does not when children exist.?p=admin&c=servers§ion=addand?p=admin&c=admins§ion=add-admin. Confirm no second left rail and no duplicate Add button in the page header.config.enableprotest/config.enablesubmit/config.enablegroupbanning. Confirm those Bans children disappear from the accordion../sbpp.sh phpstanand./sbpp.sh test --filter=AdminNavCatalogTest|AdminBansFeatureToggleTest|AdminAdminsSearchTest./sbpp.sh e2e --grep "admin-tabs|sidebar-sticky|admin-admins-density|routing-truthiness"